juergbi commented on PR #2129: URL: https://github.com/apache/buildstream/pull/2129#issuecomment-5834301187
> Someone recently suggested to implement this as a flag to `source checkout` rather than `artifact checkout`. It kinda makes sense that the build tree is related to the source, but it's also stored as part of the artifact. Maybe it makes sense to move it to a separate toplevel command? something like `bst buildtree checkout`? I think `bst artifact checkout` was actually a reasonable place for this feature. The build tree is part of the artifact. While the source is normally also part of the build tree in BuildStream, the buildtree checkout still operates solely on the artifact and there is no direct involvement of the source (plugin). The build tree is (optionally) pushed/pulled as part of `bst artifact push/pull`, not `bst source push/pull` and I assume we also don't intend to add `bst buildtree push/pull`. Or are there any ideas for further `bst buildtree` subcommands, which could make the new `buildtree` command group more useful? If most people feel a separate top-level command makes sense, I won't object, but I'm not personally convinced so far. While this is not a democracy, feel free to 👍️ on this comment if you prefer this feature to be in `bst artifact checkout` or 👎️ if you think `bst buildtree checkout` is a better fit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
