zhztheplayer commented on a change in pull request #1075: [CALCITE-2881] Add the JSON_PRETTY function URL: https://github.com/apache/calcite/pull/1075#discussion_r261510267
########## File path: core/src/test/java/org/apache/calcite/test/SqlJsonFunctionsTest.java ########## @@ -63,6 +64,7 @@ public static final String INVOC_DESC_JSON_VALUE_ANY = "jsonValueAny"; public static final String INVOC_DESC_JSON_QUERY = "jsonQuery"; public static final String INVOC_DESC_JSONIZE = "jsonize"; + public static final String INVOC_DESC_PRETTY_JSONISE = "prettyJson"; Review comment: I would suggest to change the name `PRETTY_JSONISE` to `JSON_PRETTY`, also the string value and test method names below. Using a unified name convention will benefit new developers when they do a code searching. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
