zabetak commented on a change in pull request #1033: [CALCITE-2820] Add a
version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0
URL: https://github.com/apache/calcite/pull/1033#discussion_r261550125
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/AggregateReduceFunctionsRule.java
##########
@@ -94,15 +94,23 @@
/** The singleton. */
public static final AggregateReduceFunctionsRule INSTANCE =
- new AggregateReduceFunctionsRule(operand(LogicalAggregate.class, any()),
+ new AggregateReduceFunctionsRule(operand(LogicalAggregate.class, any()),
true,
RelFactories.LOGICAL_BUILDER);
+ /** The singleton. */
+ public static final AggregateReduceFunctionsRule NO_REDUCE_SUM =
Review comment:
In particular project there may be a use-case that does not need to reduce
sum. If necessary the singleton should be added there and not here. From my
perspective it is unlikely that there will be many people who are going to use
this rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
