zabetak commented on a change in pull request #1029: [CALCITE-2824] Fix invalid
usage of RexExecutorImpl
URL: https://github.com/apache/calcite/pull/1029#discussion_r261560942
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -1407,14 +1406,10 @@ protected boolean isWeaker(MutableRel rel0, MutableRel
rel) {
return false;
}
- RexExecutorImpl rexImpl =
- (RexExecutorImpl) (rel.cluster.getPlanner().getExecutor());
- RexImplicationChecker rexImplicationChecker =
Review comment:
Instead of removing RexImplicationChecker and hiding it behind the
RexExecutor, it could be better to improve RexImplicationChecker to work with a
RexExecutor and not only with a RexExecutorImpl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
