rubenada commented on a change in pull request #884: [CALCITE-2621] New rule: 
SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate) (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/884#discussion_r261614406
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
 ##########
 @@ -127,7 +142,7 @@ public void onMatch(RelOptRuleCall call) {
             relBuilder.build(),
             correlationId,
             requiredColumns.build(),
-            SemiJoinType.of(join.getJoinType()));
+            join instanceof SemiJoin ? SemiJoinType.SEMI : 
SemiJoinType.of(join.getJoinType()));
 
 Review comment:
   What about a semiJoinTypeFunction lambda? New version committed with this 
approach

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to