danny0405 commented on a change in pull request #1081: [CALCITE-2888] Enhance
RexImplicationChecker to better handle cast
URL: https://github.com/apache/calcite/pull/1081#discussion_r261812829
##########
File path: core/src/main/java/org/apache/calcite/rex/RexExecutor.java
##########
@@ -32,6 +35,18 @@
* @param reducedValues List to which reduced expressions are appended
*/
void reduce(RexBuilder rexBuilder, List<RexNode> constExps, List<RexNode>
reducedValues);
+
+ /**
+ * Executes an {@link RexExecutable} with {@link DataContext}
+ *
+ * @param rexBuilder Rex builder
+ * @param exps Expressions
+ * @param rowType describes the structure of the input row
+ * @param dataValues {@link DataContext} to execute with
+ * @return Objects returned after applying generated code with dataValues.
+ */
+ Object[] execute(RexBuilder rexBuilder, List<RexNode> exps,
+ RelDataType rowType, DataContext dataValues);
Review comment:
-1, this should not be made into an interface method, because from this
signature or comment, user can see nothing about the relationship with
RexExecutable which could got from another method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
