asereda-gs commented on issue #1095: [CALCITE-2599] add the ASCII function URL: https://github.com/apache/calcite/pull/1095#issuecomment-471320186 Can you please change commit message to `Implement SQL ASCII function` (original `add the ASCII function` doesn't sound right) ? Also mention in commit message that it follows Postgres standard (unicode code point for non-ASCII chars). Otherwise it looks good to me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
