vvysotskyi commented on a change in pull request #90: [CALCITE-2950] Avatica
DriverVersion.load leaks InputStream
URL: https://github.com/apache/calcite-avatica/pull/90#discussion_r268606531
##########
File path: core/src/main/java/org/apache/calcite/avatica/DriverVersion.java
##########
@@ -96,8 +96,9 @@ public static DriverVersion load(
int minorVersion = 0;
int databaseMajorVersion = 0;
int databaseMinorVersion = 0;
+ InputStream inStream = null;
try {
- final InputStream inStream =
+ inStream =
Review comment:
Perhaps `try with resources` may be suitable here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
