joshelser commented on issue #90: [CALCITE-2950] Avatica DriverVersion.load 
leaks InputStream
URL: https://github.com/apache/calcite-avatica/pull/90#issuecomment-476635147
 
 
   It still gives me heartburn that the `catch (IOException)` at the bottom of 
this try-block doesn't re-throw the exception, but this isn't due to the change 
you've made. This change looks fine as-is.
   
   @leonliao do you have interest in changing that next?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to