siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-479206930 @zabetak , I have addressed the comments > > I need something like config.getRelBuilderFactory().getFilterFactory() > > The factories are inside the created RelBuilder. Can't you use something like: > `final RelNode filter = relBuilder.filter(convertedWhere2);` > or > `relBuilder.push(bb.root);` > `final RelNode filter = relBuilder.filter(convertedWhere2);` > for instance? > I didn't really look how the relBuilder is used previously but I guess should be something similar. Thanks @zabetak , I was able to use the factory in RelBuilder. I have addressed the other comments as well. Please review when you get a chance
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
