zhztheplayer commented on a change in pull request #1146: [CALCITE-2975] Add
the JSON_REMOVE function
URL: https://github.com/apache/calcite/pull/1146#discussion_r273927799
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -5379,6 +5381,34 @@ SqlCall JsonLengthFunctionCall() :
}
}
+SqlCall JsonRemoveFunctionCall() :
+{
+ final List<SqlNode> elements = new ArrayList<SqlNode>();
+ final SqlNode[] otherArgs = new SqlNode[1];
Review comment:
I think the variable names such as `elements`, `otherArgs` don't make sense.
Could you please improve a bit? Since the JSON_REMOVE's arg definition is
different from others. E.g. `jsonDoc`, `pathExprs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
