my7ym commented on a change in pull request #1152: [CALCITE-2962] RelStructuredTypeFlattener generates wrong types for n… URL: https://github.com/apache/calcite/pull/1152#discussion_r276382850
########## File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml ########## @@ -867,6 +867,17 @@ LogicalProject(ZIP=[$4]) LogicalFilter(condition=[=($3, 'abc':VARCHAR(20))]) LogicalProject(EMPNO=[$0], STREET=[$1.STREET], CITY=[$1.CITY], ZIP=[$1.ZIP], STATE=[$1.STATE], STREET5=[$2.STREET], CITY6=[$2.CITY], ZIP7=[$2.ZIP], STATE8=[$2.STATE]) LogicalTableScan(table=[[CATALOG, SALES, EMP_ADDRESS]]) +]]> + </Resource> + </TestCase> + <TestCase name="testSelectNestedColumnType"> + <Resource name="plan"> + <![CDATA[ +LogicalProject(COORD=[$0]) Review comment: Thanks man! Let me know when you approve. I will stash commits and append my name in the commit message as last time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services