chunweilei commented on a change in pull request #1164: [CALCITE-2998]
RexCopier should support all rex types (Chunwei Lei)
URL: https://github.com/apache/calcite/pull/1164#discussion_r277311551
##########
File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java
##########
@@ -52,11 +53,30 @@ private RelDataType copy(RelDataType type) {
}
public RexNode visitOver(RexOver over) {
- throw new UnsupportedOperationException();
+ final boolean[] update = null;
+ return new RexOver(copy(over.getType()), over.getAggOperator(),
+ visitList(over.getOperands(), update), visitWindow(over.getWindow()),
+ over.isDistinct(), over.ignoreNulls());
}
public RexWindow visitWindow(RexWindow window) {
Review comment:
The difference is that in this method the type of RexOver is `
copy(over.getType())` instead of `over.getType()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
