ambition119 commented on a change in pull request #1209: [CALCITE-2601] Support
REVERSE(str) in SqlFunctions
URL: https://github.com/apache/calcite/pull/1209#discussion_r284528796
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1501,6 +1501,16 @@ public SqlOperandCountRange getOperandCountRange() {
OperandTypes.CHARACTER,
SqlFunctionCategory.STRING);
+ public static final SqlFunction REVERSE =
+ new SqlFunction(
+ "REVERSE",
+ SqlKind.REVERSE,
+ ReturnTypes.ARG0_NULLABLE_VARYING,
+ null,
Review comment:
> Cause it is not standard, maybe we should not add the `REVERSE`
implementation in `SqlStdOperatorTable`, move it directly to
`SqlLibraryOperators` is more acceptable.
thank you review this pr, I fix these code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
