julianhyde commented on issue #1239: Fix precedence issue in GROUPING SETS with 
node lists
URL: https://github.com/apache/calcite/pull/1239#issuecomment-496706757
 
 
   You wrote `operand.unparse(writer, getLeftPrec() + 1, getRightPrec() + 1)` 
but it seems that `operand.unparse(writer, getLeftPrec(), getRightPrec())` is 
sufficient to pass the test case.
   
   This is usually the case. Whatever is inside the operand just needs to use 
enough parentheses (or whatever) sufficient to overcome the gravitational 
attraction of whatever is surrounding it.
   
   I'll fix up, unless you object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to