zhztheplayer commented on a change in pull request #1253: [CALCITE-3073]
Support read from special timestamp in KafkaAdapter
URL: https://github.com/apache/calcite/pull/1253#discussion_r291169304
##########
File path:
kafka/src/main/java/org/apache/calcite/adapter/kafka/KafkaStreamTable.java
##########
@@ -50,7 +61,13 @@
* implemented as a STREAM table.
*/
public class KafkaStreamTable implements ScannableTable, StreamableTable {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(KafkaStreamTable.class);
+
final KafkaTableOptions tableOptions;
+ // Identify whether the seekToTimestamp method has been executed,
Review comment:
I'm not a native English speaker but I guess here we have grammar issues.
How about the following:
```
// Identify whether the method "seekToTimestamp" has been already called.
//
// The method can only be called only once, otherwise the consumer will seek
// to the specified offset again, which leads to consumption of old data.
```
And I think it's better to use line 2 to document the method
"seekToTimestamp" directly, and leave line 1 there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
