wenhuitang commented on a change in pull request #1271: [CALCITE-3112]Support
Window in RelToSqlConverter
URL: https://github.com/apache/calcite/pull/1271#discussion_r299765985
##########
File path:
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
##########
@@ -203,6 +205,30 @@ public Result visit(Project e) {
return builder.result();
}
+ /** @see #dispatch */
+ public Result visit(Window e) {
+ Result x = visitChild(0, e.getInput());
+ Builder builder = x.builder(e);
Review comment:
I did this because that the Window does not requires Clause, it rewrites
the selectlist. And it seems that x.builder(e) produces a select for Window's
input node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
