jinxing64 opened a new pull request #1307: [CALCITE-3182] Trim unused fields for plan of materialized-view before matching. URL: https://github.com/apache/calcite/pull/1307 ## What changes were proposed in this pull request? In current code, before matching query with materialized-view, unused fields of query is trimmed but materialized-view is not. Thus below simple SQL fails to be matched though query and materialized- view are exactly the same: ``` @Test public void testMaterializationAfterTrimingOfUnusedFields() { String sql = "select \"y\".\"deptno\", \"y\".\"name\", \"x\".\"sum_salary\"\n" + "from\n" + " (select \"deptno\", sum(\"salary\") \"sum_salary\" from \"emps\" group by \"deptno\") \"x\"\n" + " join\n" + " \"depts\" \"y\"\n" + " on \"x\".\"deptno\"=\"y\".\"deptno\"\n"; checkMaterialize(sql, sql); } ``` Checking `CalciteMaterializer` https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalciteMaterializer.java#L83 , I think the code intends to do the trimming, but didn't call the method. Since unused fields of query is trimmed anyway https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java#L995 , thus I think there's no necessity to keep the materialized-view un-trimmed ## How was this patch tested? Added new test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
