jinxing64 commented on a change in pull request #1310: [CALCITE-3113] 
Equivalent MutableAggregates with different row types should match with each 
other.
URL: https://github.com/apache/calcite/pull/1310#discussion_r304312020
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
 ##########
 @@ -593,6 +593,23 @@ assert equalType(
     return substitutions;
   }
 
+  /**
+   * Equivalence checking for row types, but except for the field names.
+   */
+  private boolean rowTypesAreEquivalent(
+      MutableRel rel0, MutableRel rel1, Litmus litmus) {
+    // Validation checking for row type, but except for the field names.
+    assert rel0.rowType.getFieldCount() == rel1.rowType.getFieldCount()
 
 Review comment:
   THX Danny,
   I updated, please check~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to