julianhyde commented on issue #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect. URL: https://github.com/apache/calcite/pull/1285#issuecomment-513328266 @michaelmior I have a different (possibly contraversial) opinion on this one. If a change fixes a bug, and if the bug can be concisely described in terms that make sense to the end user, then the ideal commit message is just the bug description. My gold standard is: what is the most useful thing to put in the release notes? Since the message describes a problem, it is clear from the context that the change is a fix for the bug. Occasionally a message is ambiguous. E.g. "Validator converts unquoted field names to upper case". Is that the problem or the solution? So I'd reword to "Validator should convert field names to upper case" or "Validator should not convert field names to upper case". The second paragraph of the commit message can describe how you fixed the problem. If it's not obvious from the code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
