rubenada commented on a change in pull request #1351: [CALCITE-3226] Expand
view should keep the alias expanded view
URL: https://github.com/apache/calcite/pull/1351#discussion_r310468472
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -1054,6 +1054,11 @@ public RelBuilder scan(Iterable<String> tableNames) {
final RelNode scan = scanFactory.createScan(cluster, relOptTable);
push(scan);
rename(relOptTable.getRowType().getFieldNames());
+
+ // When the node is not a TableScan but from expansion, we add the alias.
Review comment:
I would rephrase a bit the comment line, for example something like:
"..., we need to explicitly add the alias."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services