julianhyde commented on issue #1369: [CALCITE-2979] Add a block-based nested loop join algorithm (Khawla Mouhoubi) URL: https://github.com/apache/calcite/pull/1369#issuecomment-522707302 Critique of the javadoc (and all javadoc you write): * use '<p>' at the start of each para; * description "Implementation of ..." should be a verb, e.g. "Returns ..."; * avoid future tense "It will fetch ..." and use present tense "Fetches ..." or "The enumerator fetches ...".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
