xy2953396112 commented on a change in pull request #1411: [CALCITE-3290]
Implement evaluate method of AbstractNode
URL: https://github.com/apache/calcite/pull/1411#discussion_r317587463
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/tree/AbstractNode.java
##########
@@ -71,8 +71,12 @@ public Node accept(Shuttle shuttle) {
}
public Object evaluate(Evaluator evaluator) {
- throw new RuntimeException(
- "evaluation not supported: " + getClass() + ":" + nodeType);
+ return evaluator.evaluate(this);
+ }
+
+ public Object evaluate() {
Review comment:
changed the title and the commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services