hsyuan commented on a change in pull request #1441: [CALCITE-3324] Set
updateCount in MetaResultSet
URL: https://github.com/apache/calcite/pull/1441#discussion_r321632623
##########
File path: core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java
##########
@@ -565,14 +565,22 @@ public MetaResultSet getTableTypes(ConnectionHandle ch) {
}
callback.execute();
final MetaResultSet metaResultSet =
- MetaResultSet.create(h.connectionId, h.id, false, signature, null);
+ new MetaResultSetImpl(h.connectionId, h.id, false, signature, null,
updateCount);
Review comment:
I would prefer updating Avatica to add another `MetaResultSet.create` that
has `updateCount` parameter, instead of adding a subclass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
