shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting
new parameter from model to set it in HTTP host…
URL: https://github.com/apache/calcite/pull/1447#discussion_r322841283
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java
##########
@@ -56,14 +59,23 @@ public ElasticsearchSchemaFactory() {
try {
final String coordinatesString = (String) map.get("coordinates");
- Preconditions.checkState(coordinatesString != null,
- "'coordinates' is missing in configuration");
- final Map<String, Integer> coordinates =
mapper.readValue(coordinatesString,
- new TypeReference<Map<String, Integer>>() { });
+ final String hostsString = (String) map.get("hosts");
+ Preconditions.checkState(coordinatesString != null || hostsString !=
null,
+ "Both 'coordinates' and 'hosts' is missing in configuration. Provide
one of them.");
// create client
- final RestClient client = connect(coordinates);
+ final RestClient client;
+
+ if (coordinatesString != null) {
+ final Map<String, Integer> coordinates =
mapper.readValue(coordinatesString,
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
