amaliujia commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r326339425
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -2416,6 +2416,24 @@ LogicalProject(X=[+($0, $1)], B=[$1], A=[$0])
<Resource name="planAfter">
<![CDATA[
LogicalValues(tuples=[[{ 11, 1, 10 }, { 23, 3, 20 }]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testReduceValuesNull">
+ <Resource name="sql">
+ <![CDATA[insert into sales.dept(deptno,name) values (0, 'null')]]>
Review comment:
Need to change this line as the test's query is already changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
