zabetak commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r329373064
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java
##########
@@ -142,13 +144,9 @@ public void onMatch(RelOptRuleCall call) {
// create a new join with the projected children
Join newJoinRel =
- join.copy(
Review comment:
I'm sorry @danny0405 but I don't understand what you mean by saying fixing
the merge join. I don't see a problem with the join itself; from my
understanding so far it is the bad use of copy that leads to this problem. I
agree with you that having rules modify traits is not a very elegant solution
but we are already doing it in a couple of places (other rules using copy
method). In the absence of good alternative for copy the solution of leaving
the rule treat the modification of traits seems like a decent option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
