jinxing64 commented on issue #1485: [CALCITE-2792] Stackoverflow while 
evaluating filter with large number of OR conditions
URL: https://github.com/apache/calcite/pull/1485#issuecomment-539817754
 
 
   Hi, @hsyuan may I as a question ?
   This fix replaces `createLeftCall` with `createBalancedCall` and the 
`SqlNode` converted from `RexNode` will be more 'balanced'. But what if we pass 
a `SqlNode` of left deep binary tree into `SqlValidatorImpl`, can we avoid the 
stackoverflow of SqlValidatorImpl#registerSubQueries discussed in JIRA ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to