stoty commented on a change in pull request #113: [CALCITE-3384] Support
Kerberos-authentication using SPNEGO over HTTPS
URL: https://github.com/apache/calcite-avatica/pull/113#discussion_r333455903
##########
File path:
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java
##########
@@ -147,10 +147,10 @@ protected void
configureHttpsRegistry(RegistryBuilder<ConnectionSocketFactory> r
private SSLContext getSSLContext() throws Exception {
SSLContextBuilder sslContextBuilder = SSLContexts.custom();
- if (null != truststore && null != truststorePassword) {
+ if (null != truststore) {
loadTrustStore(sslContextBuilder);
Review comment:
I really shouldn't have opened this particular can of worms :)
As it turns out, there is no way to handle (or at least create) unencrypted
private keys and keystores with Java. What I thought were unencrypted keys and
keystores are in fact simply keys / keystores with the empty string as password.
The most user-friendly thing would probably be to set the default for the
key*password parameters to empty string instead of null, but for now I have
just reverted the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
