ihuzenko commented on a change in pull request #1519: [CALCITE-3424]
AssertionError thrown for user-defined table function with array argument
URL: https://github.com/apache/calcite/pull/1519#discussion_r336452651
##########
File path: core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java
##########
@@ -251,13 +253,25 @@ public static RelDataType toSql(final RelDataTypeFactory
typeFactory,
type.getFieldNames()),
type.isNullable());
} else if (type instanceof JavaType) {
- return typeFactory.createTypeWithNullability(
- typeFactory.createSqlType(type.getSqlTypeName()),
- type.isNullable());
+ Class javaClass = ((JavaType) type).getJavaClass();
+ final RelDataType nonNullType;
+ if (javaClass.isArray()) {
+ nonNullType = typeFactory.createArrayType(type.getComponentType(), -1);
+ } else if (isCollection(javaClass)) {
+ nonNullType =
typeFactory.createArrayType(typeFactory.createSqlType(SqlTypeName.ANY), -1);
+ } else {
+ nonNullType = typeFactory.createSqlType(type.getSqlTypeName());
+ }
Review comment:
There is no need to use ```JavaToSqlTypeConversionRules``` here because
```type``` contains SqlTypeName. Most probably this check just need to be
rewritten to switch case based on the enum values and further java class
investigation isn't necessary here. To be honest the API of ```typeFactory```
which promises to ```createSqlType(...)``` for sqlTypeName and implicitly
throws assertion errors is really bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
