hsyuan commented on a change in pull request #1451: [CALCITE-3334] Refinement
for Substitution-Based MV Matching
URL: https://github.com/apache/calcite/pull/1451#discussion_r337287184
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -916,18 +940,22 @@ public RexSimplify getSimplify() {
* Result of an application of a {@link UnifyRule} indicating that the
* rule successfully matched {@code query} against {@code target} and
* generated a {@code result} that is equivalent to {@code query} and
- * contains {@code target}.
+ * contains {@code target}. {@code triedEnough} indicates whether there's
+ * no need to do matching for the same query node again.
*/
protected static class UnifyResult {
private final UnifyRuleCall call;
// equivalent to "query", contains "result"
private final MutableRel result;
- UnifyResult(UnifyRuleCall call, MutableRel result) {
+ private final boolean triedEnough;
Review comment:
Also add a comment to explain it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
