danny0405 commented on a change in pull request #1592: [CALCITE-3512] Support
type cast from Time/TimeStamp to Integer/Long
URL: https://github.com/apache/calcite/pull/1592#discussion_r347746687
##########
File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
##########
@@ -806,6 +806,22 @@ private static boolean isNumeric(Class type) {
.returnsUnordered("V=1970-01-01");
}
+ @Test public void testDateCanCompare2() {
+ final String sql = "select a.v1, a.v2\n"
Review comment:
Can we merge `DateCanCompare2` into `DateCanCompare` to test three data
types ? Or can you split `testDateCanCompare2` into `testTimeCanCompare` and
`testTimestampCanCompare` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
