vlsi commented on a change in pull request #1375:
[WIP][CALCITE-3140][CALCITE-3141] Failures in slow tests & CI
URL: https://github.com/apache/calcite/pull/1375#discussion_r349280659
##########
File path: build.gradle.kts
##########
@@ -590,6 +587,16 @@ allprojects {
}
}
}
+
+ register<Test>("testSlow") {
+ group = LifecycleBasePlugin.VERIFICATION_GROUP
+ description = "Runs the slow unit tests."
+ useJUnitPlatform() {
+ includeTags("slow")
+ }
+ jvmArgs("-Xmx6g")
+ jvmArgs("-Djdk.net.URLClassPath.disableClassPathURLCheck=true")
Review comment:
This is OK, however, I would move it closer to `withType<Test>` (before it
or after it) just to keep the related things together.
It would add `testSlow` task to all the projects that have tests with `slow`
tag.
Alternative option is to add new folders like `src/slowTests/java/...` (it
is typically used for `src/integTests/...`, `src/jmh/...`), but I think `slow`
tag is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
