DonnyZone commented on a change in pull request #1592: [CALCITE-3512] Query
fails when comparing Time/TimeStamp types
URL: https://github.com/apache/calcite/pull/1592#discussion_r349425319
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -1061,10 +1061,22 @@ public static Expression convert(Expression operand,
Type fromType,
Expressions.convert_(operand, toBox.primitiveClass),
toBox);
} else if (fromType == java.sql.Date.class) {
- if (toBox == Primitive.INT) {
+ if (toType == int.class) {
Review comment:
There is a similar function in `RexToLixTranslator`. Can we move all these
util functions to `EnumUtils`? I think it can make `RexToLixTranslator` more
clean.
```
static boolean isA(Type fromType, Primitive primitive) {
return Primitive.of(fromType) == primitive
|| Primitive.ofBox(fromType) == primitive;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
