yanlin-Lynn commented on a change in pull request #1642: [CALCITE-3583] Support
serialized to json and deserialized from json for Exchange relation operator
URL: https://github.com/apache/calcite/pull/1642#discussion_r357498162
##########
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##########
@@ -761,6 +762,22 @@
assertThat(s, isLinux(expected));
}
+ @Test public void testExchange() {
+ final FrameworkConfig config = RelBuilderTest.config().build();
+ final RelBuilder builder = RelBuilder.create(config);
+ final RelNode rel = builder
+ .scan("EMP")
+ .exchange(RelDistributions.hash(ImmutableList.of(0, 1)))
+ .build();
+ String relJson = RelOptUtil.dumpPlan("", rel,
Review comment:
Well, actually, I'm not sure what's the benefit of using so much final in
these tests.
But it seems it has no harm, so yes, it's better to add a final here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
