danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-568383147 I tried to modify based on your PR to treat `Tumble` as a normal table value function: use `SqlKind.OTHER_FUNCTION` to make the code works as the same, still in the progress ~ During the working, i have a feeling that the `Descriptor` should not have a different scope with the table value function, in the table value function's first operand scope, we should have see the referenced table columns. We may also need to add more tests: - For SqlParserTest: to test all the syntax with positive/negative cases - For SqlValidatorTest: test you operands/return type inference defined in the 2 new operators - For SqlToRelConverterTest: test your plan is correct after the conversion
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
