danny0405 commented on a change in pull request #1703: WIP: [CALCITE-2450]
Reorder RexCall predicates to a canonical form
URL: https://github.com/apache/calcite/pull/1703#discussion_r361887239
##########
File path: core/src/main/java/org/apache/calcite/rex/RexCall.java
##########
@@ -127,7 +143,23 @@ protected final StringBuilder
appendOperands(StringBuilder sb) {
includeType = RexDigestIncludeType.NO_TYPE;
}
}
- sb.append(((RexLiteral) operand).computeDigest(includeType));
+ operandDigests.add(((RexLiteral) operand).computeDigest(includeType));
+ }
+ int totalLength = (operandDigests.size() - 1) * 2; // commas
+ for (String s : operandDigests) {
Review comment:
How about the operands are empty ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
