vlsi commented on a change in pull request #1704: [CALCITE-3644] Add 
ProjectSetOpTransposeRule to normalize materialized view
URL: https://github.com/apache/calcite/pull/1704#discussion_r366172973
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java
 ##########
 @@ -173,6 +173,23 @@ public RexNode get(int index) {
         .collect(Collectors.toList());
   }
 
+  /**
+   * Construct expression list of Project by the given fields of the input.
+   */
+  public static List<RexNode> createProjects(final MutableRel child,
+      final List<RexNode> projs) {
 
 Review comment:
   What does it do?
   Is it really a public API?
   
   What if I pass `+($0, 1)` as a project expression what would it do?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to