vvysotskyi commented on a change in pull request #1850: [CALCITE-3847]
Decorrelation for join with lateral table outputs wron…
URL: https://github.com/apache/calcite/pull/1850#discussion_r389624274
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -1032,6 +1033,13 @@ public Frame decorrelateRel(LogicalSnapshot rel) {
return decorrelateRel((RelNode) rel);
}
+ public Frame decorrelateRel(LogicalTableFunctionScan rel) {
Review comment:
This class also contains methods for non-logical rel nodes, for example,
`decorrelateRel(Filter rel)`. Should be `TableFunctionScan` there instead of
`LogicalTableFunctionScan` to ensure that this issue wouldn't be reproduced for
other implementations of `TableFunctionScan`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
