[GitHub] [calcite] chunweilei commented on a change in pull request #1848: [CALCITE-3845] CASE WHEN expression with nullability CAST is considered as reduced wrongly in ReduceExpressionsRule

[GitBox]

chunweilei commented on a change in pull request #1848: [CALCITE-3845] CASE 
WHEN expression with nullability CAST is considered as reduced wrongly in 
ReduceExpressionsRule
URL: https://github.com/apache/calcite/pull/1848#discussion_r389748026
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java
 ##########
 @@ -302,6 +302,7 @@ public ProjectReduceExpressionsRule(Class<? extends 
Project> projectClass,
           Lists.newArrayList(project.getProjects());
       if (reduceExpressions(project, expList, predicates, false,
           matchNullability)) {
+        assert !project.getProjects().equals(expList);
 
 Review comment:
   Ok. Will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services