vlsi commented on a change in pull request #1827: [CALCITE-3821]
RelOptUtil::containsMultisetOrWindowedAgg doesn't real…
URL: https://github.com/apache/calcite/pull/1827#discussion_r389850722
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -3418,28 +3415,19 @@ public static RelNode projectMapping(
return projectFactory.createProject(rel, ImmutableList.of(), exprList,
outputNameList);
}
- /** Predicate for whether a {@link Calc} contains multisets or windowed
- * aggregates. */
- public static boolean containsMultisetOrWindowedAgg(Calc calc) {
- return !(B
- && RexMultisetUtil.containsMultiset(calc.getProgram())
- || calc.getProgram().containsAggs());
+ /** Predicate for if a {@link Calc} does not contain windowed aggregates. */
+ public static boolean notContainsWindowedAgg(Calc calc) {
Review comment:
So far public API is whatever is `public` and that is not marked as
"private/internal" in javadoc.
I've recently added `apiguardian` dependency, so we can use `@API` to
classify APIs.
However, in general we consider all Java-public methods to be part of
published API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
