wenhuitang commented on a change in pull request #1862: [CALCITE-3864] Add
Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and
correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION
URL: https://github.com/apache/calcite/pull/1862#discussion_r397033603
##########
File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
##########
@@ -460,6 +460,15 @@ public static ByteString concat(ByteString s0, ByteString
s1) {
return s0.concat(s1);
}
+ /** SQL function CONCAT(arg, ...)*/
Review comment:
I noticed this problem too, and I found that creating two SqlFunction for
CONCAT is redundant and unnecessary, what's more, it maybe cause exception when
look up method.
I have updated this pull request, concat function is equivalent to ||
operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
