wenhuitang commented on a change in pull request #1862: [CALCITE-3864] Implement Concat function URL: https://github.com/apache/calcite/pull/1862#discussion_r397801950
########## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ########## @@ -332,6 +334,8 @@ NullPolicy.STRICT); defineMethod(CONCAT, BuiltInMethod.STRING_CONCAT.method, NullPolicy.STRICT); + defineMethod(CONCAT2, BuiltInMethod.STRING_CONCAT.method, NullPolicy.STRICT); Review comment: Still keep defineMethod for CONCAT2 for looking up method clearly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services