hsyuan commented on a change in pull request #1869: [CALCITE-3868] Remove redundant ruleSet and ruleNames in VolcanoPlanner URL: https://github.com/apache/calcite/pull/1869#discussion_r398362363
########## File path: core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java ########## @@ -275,7 +253,7 @@ void executeInstruction( LOGGER.trace("Applying rule class {}", instruction.ruleClass); if (instruction.ruleSet == null) { instruction.ruleSet = new LinkedHashSet<>(); - for (RelOptRule rule : allRules) { + for (RelOptRule rule : mapDescToRule.values()) { Review comment: Yes, will do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services