danny0405 commented on a change in pull request #1862: [CALCITE-3864] Implement
Concat function
URL: https://github.com/apache/calcite/pull/1862#discussion_r398603904
##########
File path: core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java
##########
@@ -655,6 +655,59 @@ public int size() {
return ret;
};
+
+ /**
+ * Type-inference strategy for String concatenation.
+ * Result is varying if either input is; otherwise fixed.
+ * For example,
+ *
+ * concat(cast('a' as varchar(2)), cast('b' as varchar(3)),cast('c' as
varchar(2)))
+ * returns varchar(7),
+ *
+ * concat(cast('a' as varchar), cast('b' as varchar(2), cast('c' as
varchar(2))))
+ * returns varchar,
+ *
+ * concat(cast('a' as varchar(65535)), cast('b' as varchar(2)), cast('c' as
varchar(2)))
+ * returns varchar
+ */
Review comment:
Start with `<p>` If there is a blank line ahead. And end with dot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
