rubenada commented on a change in pull request #1870: [CALCITE-3846]
EnumerableMergeJoin: wrong comparison of composite key with null values
URL: https://github.com/apache/calcite/pull/1870#discussion_r399124159
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -3836,6 +3837,7 @@ public void remove() {
// extra predicate in case of non equi-join, in case of equi-join it will
be null
private final Predicate2<TSource, TInner> extraPredicate;
private final Function2<TSource, TInner, TResult> resultSelector;
+ private final Comparator<TKey> comparator; // possibly null (compareTo to
be used in that case)
private boolean done;
Review comment:
sorry, I misunderstood you, I will change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
