danny0405 commented on a change in pull request #1878: [CALCITE-3782]Bitwise
agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
URL: https://github.com/apache/calcite/pull/1878#discussion_r399615184
##########
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##########
@@ -9074,6 +9083,11 @@ protected void checkAggType(SqlTester tester, String
expr, String type) {
false);
final String[] values = {"1", "2", "2"};
tester.checkAgg("bit_or(x)", values, 3, 0);
+ final String[] binaryValues = {
+ "CAST(x'01' AS BINARY)",
+ "cast(x'02' as BINARY)",
+ "cast(x'02' AS BINARY)"};
Review comment:
Add a test for `null` value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
