neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching 
for ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-607168132
 
 
   @vlsi I have addressed your comments.
   1) Set max cache to 0 to disable global caching.
   2) Use `CacheBuilder.newBuilder().softValues()`, does not use weak values, 
because I think soft references are most commonly used to implement 
memory-sensitive caches, they live longer until before an OOM is thrown.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to