hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add
abstractConverter only between derived and required traitset
URL: https://github.com/apache/calcite/pull/1860#discussion_r405929414
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java
##########
@@ -157,6 +157,11 @@ public RelNode accept(RexShuttle shuttle) {
return copy(traitSet, getInput(), collation, offset, fetch);
}
+ @Override public boolean isEnforcer() {
+ return offset == null && fetch == null
Review comment:
When we have a query `select * from foo limit 5`, there is still a sort
operator in the plan, but it doesn't do any sort work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
