[GitHub] [calcite] hsyuan commented on a change in pull request #1878: [CALCITE-3782]Bitwise agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type

[GitBox]

hsyuan commented on a change in pull request #1878: [CALCITE-3782]Bitwise agg 
operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type
URL: https://github.com/apache/calcite/pull/1878#discussion_r409905987
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/sql/fun/SqlBitOpAggFunction.java
 ##########
 @@ -62,6 +62,17 @@ public SqlBitOpAggFunction(SqlKind kind) {
   }
 
   @Override public Optionality getDistinctOptionality() {
-    return Optionality.IGNORED;
+    final Optionality optionality;
+
+    switch (kind) {
+    case BIT_AND:
+    case BIT_OR:
+      optionality = Optionality.IGNORED;
+      break;
+    default:
 
 Review comment:
   Can you add BIT_XOR before default?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services